Re: [patch] Fix vectorizer testsuite failures, including PR 46312

[Ira Rosen <IRAR at il dot ibm dot com>]

gcc-patches-owner@gcc.gnu.org wrote on 15/11/2010 03:47:46 PM:

> From: Ira Rosen/Haifa/IBM@IBMIL
> To: "H.J. Lu" <hjl.tools@gmail.com>
> Cc: gcc-patches@gcc.gnu.org
> Date: 15/11/2010 03:48 PM
> Subject: Re: [patch] Fix vectorizer testsuite failures, including PR
46312
> Sent by: gcc-patches-owner@gcc.gnu.org
>
>
>
> "H.J. Lu" <hjl.tools@gmail.com> wrote on 15/11/2010 03:40:44 PM:
>
> > On Mon, Nov 15, 2010 at 4:02 AM, Ira Rosen <IRAR@il.ibm.com> wrote:
> > >
> > > Hi,
> > >
> > > vect-scal-opt*.c check vector shift with scalar shift argument. So I
> added
> > > vect_shift_scalar keyword for them. I only put x86_64-*-* there. What
> other
> > > targets support such shifts?
> >
> > i?86-*-* with SSE2 enabled?
>
> vect.exp adds -msse2 for i?86-*-*. So, I'll add i?86-*-*.

But vect-scal-opt*.c use /* { dg-options "-O -fdump-tree-veclower" } */, so
we may need to remove it and run the tests with vect.exp options.

Ira


>
> Thanks,
> Ira
>
> >
> > > pr43430-2.c uses dg-options to set compiler flags, overriding target
> > > dependent vectorization flags in vect.exp, and rather than that the
> flags
> > > are the same as the default flags in vect.exp (I don't think that -O3
> is
> > > needed). So I removed dg-options from the test.
> > >
> > > The rest of the tests test reverse access which is supported only on
> > > targets that support misaligned accesses. I added vect_hw_misalign to
> these
> > > tests.
> > >
> > > Tested on powerpc64-suse-linux and x86_64-suse-linux.
> > >
> > > OK to apply (after possible update of
> > > check_effective_target_vect_shift_scalar)?
> > >
> > > Thanks,
> > > Ira
> > >
> > >
> > > testsuite/ChangeLog:
> > >
> > > ? ? ? ?PR tree-optimization/46312
> > > ? ? ? ?* gcc.dg/vect/vect-scal-opt2.c: Expect to pass only on targets
> > > ? ? ? ?that support vector shifts with scalar shift argument.
> > > ? ? ? ?* gcc.dg/vect/vect-scal-opt.c, gcc.dg/vect/vect-scal-opt1.c:
> > > Likewise.
> > > ? ? ? ?* gcc.dg/vect/vect-114.c: Expect to pass only on targets that
> > > ? ? ? ?support misaligned data accesses.
> > > ? ? ? ?* gcc.dg/vect/pr43432.c, gcc.dg/vect/vect-15.c: Likewise.
> > > ? ? ? ?* gcc.dg/vect/pr43430-2.c: Remove dg-options.
> > > ? ? ? ?* lib/target-supports.exp
> (check_effective_target_vect_shift_scalar):
> > > ? ? ? ?New.
> > >
> >
> >
> > --
> > H.J.
>