Re: PATCH RFA: build machinery: Add Go support to libtool

[Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>]

* Ian Lance Taylor wrote on Wed, Nov 03, 2010 at 09:31:27PM CET:
> This patch, similar to the one I just sent for config/go.m4, adds Go
> support to libtool.  This is not used by anything at present, but will
> be used by libgo when it is committed.  I have proposed a similar patch
> to the libtool maintainers.  When gcc includes a version of libtool with
> support for Go, this patch can go away.
> 
> Bootstrapped on x86_64-unknown-linux-gnu.  OK for mainline?

This patch is lacking a ChangeLog entry.

Did you ensure that none of the configure scripts (nor aclocal.m4 files)
in mainline change when the patch is applied (even when
--enable-maintainer-mode is used)?

This patch makes Libtool machinery go out of sync with upstream, which
is against the GCC commit rules.  I'm basically just waiting for
Autoconf to commit before pushing the Libtool patch, however.

This also means that when we update Libtool in GCC, we'd need to switch
to a git version again then.  But probably that's unavoidable anyway due
to fixes needed for --with-sysroot support in Libtool (Paolo?).

Thanks,
Ralf

> Index: libtool.m4
> ===================================================================
> --- libtool.m4	(revision 166249)
> +++ libtool.m4	(working copy)
> @@ -799,6 +799,7 @@ AC_DEFUN([LT_LANG],
>  m4_case([$1],
>    [C],			[_LT_LANG(C)],
>    [C++],		[_LT_LANG(CXX)],
> +  [Go],			[_LT_LANG(GO)],
>    [Java],		[_LT_LANG(GCJ)],
>    [Fortran 77],		[_LT_LANG(F77)],
>    [Fortran],		[_LT_LANG(FC)],
[...]