This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [testsuite] Add -msse to all i386 vector tests (PR target/46280)
On Mon, Nov 8, 2010 at 5:25 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Mon, Nov 8, 2010 at 7:53 AM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>> Uros Bizjak <ubizjak@gmail.com> writes:
>>
>>> On Fri, Nov 5, 2010 at 8:49 PM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>>>
>>>> gcc.target/i386/vect-args.c still fails because the testcase is cycled
>>>> through several options and only passes with -msse2. ?Adding -msse
>>>> obviously doesn't help. ?I'm not sure what the best way to handle this
>>>> is.
>>>
>>> IMO, you should add -Wno-psabi to dg-options. The test is already
>>> compiled with -w, so we are not interested in complier warnings or
>>> notes here.
>>
>> Ok. ?Here's the patch I've come up with. ?It includes the fixed wording
>> in the ABI warning message, an updated testcase to reflect this, and
>> omits the sse effective-target keyword from the compile tests where it
>> is unnecessary.
>>
>> Bootstrapped without regressions on i386-pc-solaris2.8 (with the sse
>> keyword still included) and i386-pc-solaris2.11.
>>
>
> I agree with Uros. ?We should add -Wno-psabi since we already use
> -w.
No, the majority of tests test vector modes, so they should use -msse
to enable SSE registers. We don't want to test generic vectorization
here, and don't want to put any -Wpsabi error under the carpet...
The other issue is with vect-args.c. Here we indeed test that values
are passed even without -msse. So we have no other choice than
-Wno-psabi.
So, the patch is OK.
Uros.