This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Fix bootstrap/46358


Quoting Richard Henderson <rth@redhat.com>:

On 11/08/2010 01:57 AM, Joern Rennecke wrote:
+	  gcc_assert ((allocate & (HOST_WIDE_INT) 0xffffffff) == allocate);
+	  gcc_assert (((HOST_WIDE_INT) args_size & (HOST_WIDE_INT) 0xffffffff)
 		      == (HOST_WIDE_INT) args_size);

Please just promote args_size to HOST_WIDE_INT.

It already is - this has no effect because HOST_WIDE_INT is just a 32 bit long.
Or do you mean unsigned HOST_WIDE_INT?



+	  argval = (HOST_BITS_PER_WIDE_INT > 32
+		    ? (HOST_WIDE_INT) args_size << 32 : 0) + allocate;

Cleaner to split to the shift in two.

Like this? argval = ((HOST_WIDE_INT) args_size << 16) << 16) + allocate;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]