This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [Patch, ObjC, test-suite, committed] "next-ify" recent ObjC test-suite additions.
- From: "Nicola Pero" <nicola dot pero at meta-innovation dot com>
- To: "IainS" <developer at sandoe-acoustics dot co dot uk>
- Cc: "GCC Patches" <gcc-patches at gcc dot gnu dot org>, "Mike Stump" <mrs at gcc dot gnu dot org>
- Date: Thu, 4 Nov 2010 19:45:34 +0100 (CET)
- Subject: RE: [Patch, ObjC, test-suite, committed] "next-ify" recent ObjC test-suite additions.
- References: <EA03624C-4217-4F5E-AB2A-555F2683D04B@sandoe-acoustics.co.uk>
Looks great. :-)
I have one comment ...
+#ifdef __NEXT_RUNTIME__
++ (id) initialize ;
+#endif
+#ifdef __NEXT_RUNTIME__
++ (id) initialize { return self; }
+#endif
(by the way, there is a space after 'initialize', you should remove it)
Shall we remove the #ifdef __NEXT_RUNTIME__ and always add a +initialize in all tests
for both runtimes ? ie, in all tests we can simply add
+ (id) initialize;
+ (id) initialize { return self; }
as the first method in all classes. Since the +initialize is not part of the test, I
find it less distracting to remove the #ifdefs and give it as little visual prominence
as possible, since it's almost never relevant to what is being tested.
Ie, I'm happy to agree that we'll add +initialize in all tests for the GNU runtime as well,
and we can drop the #ifdefs. :-)
Thanks
-----Original Message-----
From: "IainS" <developer@sandoe-acoustics.co.uk>
Sent: Thursday, 4 November, 2010 19:28
To: "GCC Patches" <gcc-patches@gcc.gnu.org>
Cc: "Mike Stump" <mrs@gcc.gnu.org>, "Nicola Pero" <nicola.pero@meta-innovation.com>
Subject: [Patch, ObjC, test-suite, committed] "next-ify" recent ObjC test-suite additions.
Hello, this applies a few tweaks to the test cases recently applied
for @property.
It also tidies up the forward-1.
property-2 & 3 are no longer relevant to the implementation - so those
are removed.
applied as r166321 (r166322 for an update to the Changelog).
thanks
Iain