This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, middle-end]: Fix also PR46292 (was: Fix PR 44569)


On Wed, Nov 3, 2010 at 11:13 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> It was "obvious" in the sense that avoided ICE by correcting VOIDmode
>> for vector mode operands. So, it was either ICE or to dig a little
>> deeper in the operand itself for a correct mode. Due to this logic,
>> the patch can't cause any regression.
>
> But that's backward, the patch must fix a regression to be put on branches; at
> a minimum, there must be a testcase to show that there is a real problem to
> be fixed on the branches. ?There is neither in this case AFAICS.

OK, I can revert the patch on branches.

Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]