Re: [PATCH] Add attribute((target("..."))) and pragma target to PowerPC

["Joseph S. Myers" <joseph at codesourcery dot com>]

On Mon, 1 Nov 2010, Michael Meissner wrote:

> On Mon, Nov 01, 2010 at 01:49:06PM -0400, Michael Meissner wrote:
> > The simplest way to fix this is to require the user on 32-bit to use an
> > explicit -maltivec-abi switch if they want to switch to a power7 cpu or enable
> > altivec (similarly for the rs6000_spe_abi, rs6000_float_gprs, and
> > rs6000_darwin64_abi variables).
> 
> Whoops, that should be -mabi=altivec.
> 
> The following patch applied on top of my previous patch, will give an error if
> any option changes the various abi's.  It also changes the debug information
> somewhat.  Does this answer your objection?

It looks like it.  Note that there are problems with diagnostic 
formatting:

> +	error ("You cannot change long double size within a target attribute "
> +	       "or pragma");

Diagnostics should not start with a capital letter, and "You cannot" is 
not the normal style; I'd think the message should be something like

  error ("target attribute or pragma changes long double size");

or use sorry () if you think the feature should be supported (that's more 
likely with the AltiVec ABI, though maybe that should be a separate 
attribute instead) and the lack of support is a limitation of the 
implementation.

> +	error ("You cannot switch to the altivec abi within a target "

"AltiVec" and "ABI".  Likewise elsewhere.

-- 
Joseph S. Myers
joseph@codesourcery.com