This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC] Fix libstdc++ test fails with emutls

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Jie Zhang <jie at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, Benjamin Kosnik <bkoz at redhat dot com>
Date: Mon, 01 Nov 2010 14:59:42 +0100
Subject: Re: [RFC] Fix libstdc++ test fails with emutls
References: <4CCE5416.1000001@codesourcery.com> <20101101074800.GX29412@tyan-ft48-01.lab.bos.redhat.com>

On 11/01/2010 08:48 AM, Jakub Jelinek wrote:
> On Mon, Nov 01, 2010 at 01:45:58PM +0800, Jie Zhang wrote:
>   
>> mutex:704: undefined reference to `__emutls_v._ZSt15__once_callable'
>>
>> This patch should fix this error by exporting such like symbols.
>>
>> Is this patch OK?
>>     
> You shouldn't be exporting symbols that weren't (even by mistake) exported
> earlier in older symbol versions, always add new symbols to the latest
> version (GLIBCXX_3.4.15 right now).
>   
Indeed. Consider the patch adding the symbols @ GLIBCXX_3.4.15
(preferably with a one-line comment before) preapproved.

Paolo.

References:
- [RFC] Fix libstdc++ test fails with emutls
  - From: Jie Zhang
- Re: [RFC] Fix libstdc++ test fails with emutls
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]