This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Add gcc-ar, gcc-ranlib, gcc-ld wrappers


On Fri, 29 Oct 2010, Andi Kleen wrote:

> I think the only issue is Windows, but I think it's a reasonable
> requirement to have a shell installed for slim LTO. Or actually

We should not gratuitous reduce host portability.

There are cases where portability restrictions are reasonable - say the 
original LTO dependence on particular target object formats, or host 
dependencies for plugins.  But in this case the interfaces for calling 
subprocesses on many hosts already exist in libiberty and are widely used 
in GCC; not using them is gratuitous.

> > By building up a string like this you'll have lots of problems when 
> > arguments contain spaces.  
> 
> I declare that just not supported right now.

Just declaring things unsupported like that is inappropriate.  
Unsupported things need documentation, but it's clearly better just to 
support them in this case.

> > Apart from the issues with spaces, echo will process some options on some 
> > systems and this sed command will happily modify option arguments that 
> > happen to contain that particular string.  As before, (POSIX) shell is not 
> > a good language in which to do this robustly (if you e.g. assume various 
> > bash features, it becomes easier).
> 
> Are these systems with funny echo supported by LTO?

echo in bash will handle -n and -e.  POSIX echo interprets backslash 
sequences in its operands.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]