This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: PR target/46195: r165965 regresses i386 darwin

From: "H.J. Lu" <hjl dot tools at gmail dot com>
To: Mike Stump <mikestump at comcast dot net>
Cc: Jack Howarth <howarth at bromo dot med dot uc dot edu>, gcc-patches at gcc dot gnu dot org, Uros Bizjak <ubizjak at gmail dot com>, Richard Henderson <rth at redhat dot com>
Date: Thu, 28 Oct 2010 20:11:16 -0700
Subject: Re: PATCH: PR target/46195: r165965 regresses i386 darwin
References: <20101028173314.GA13514@intel.com> <20101029021147.GA19391@bromo.med.uc.edu> <AANLkTi=OZuT0jrwmPThiOi=8hp=TeJr7ruY37-Fg_buw@mail.gmail.com> <71F6E3B8-F781-4AFD-884F-F0DEFA1E0EAE@comcast.net>

On Thu, Oct 28, 2010 at 8:02 PM, Mike Stump <mikestump@comcast.net> wrote:
> On Oct 28, 2010, at 10:42 PM, H.J. Lu wrote:
>>
>> OK for trunk?
>
> I'm fine with the darwin aspects of this, though, I'd like an x86/abi type
> person to review it. ?I mention this so that they don't wish for a darwin
> person to review it and remain silent.. ?:-) ?Thanks.
>

That is an issue only on 32bit Darwin since 32bit Darwin aligns long double to
16byte and passes it on stack with 4byte alignment. Other targets always use
4byte alignment.

-- 
H.J.

References:
- PATCH: PR target/46195: r165965 regresses i386 darwin
  - From: H.J. Lu
- Re: PATCH: PR target/46195: r165965 regresses i386 darwin
  - From: Jack Howarth
- Re: PATCH: PR target/46195: r165965 regresses i386 darwin
  - From: H.J. Lu
- Re: PATCH: PR target/46195: r165965 regresses i386 darwin
  - From: Mike Stump

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]