This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Ping: [PATCH] Support official CLooG.org versions.
Hi,
On Thu, Oct 28, 2010 at 4:59 AM, Sebastian Pop <sebpop@gmail.com> wrote:
> Hi,
>
> thanks for the review.
>
> On Wed, Oct 27, 2010 at 15:35, DJ Delorie <dj@redhat.com> wrote:
>>
>>> (now in CC) review this patch?
>>> http://gcc.gnu.org/ml/gcc-patches/2010-10/msg00673.html
>>
>> Aside from Ralf's concerns, I add...
>>
>> The GPL notice requires a version number, and preferably the "or any
>> later version" variant.
>
> Andreas, could you please update the text at the beginning of cloog.m4
> with the following notice:
>
> #This file is part of GCC.
>
> #GCC is free software; you can redistribute it and/or modify it under
> #the terms of the GNU General Public License as published by the Free
> #Software Foundation; either version 3, or (at your option) any later
> #version.
>
> #GCC is distributed in the hope that it will be useful, but WITHOUT
> #ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> #FITNESS FOR A PARTICULAR PURPOSE. ÂSee the GNU General Public License
> #for more details.
>
> #You should have received a copy of the GNU General Public License
> #along with GCC; see the file COPYING3. ÂIf not see
> #<http://www.gnu.org/licenses/>.
>
>
I will add this, thanks :-).
>>
>> "Runtime" checks should be avoided as they won't work when you're
>> cross-compiling. ÂDid you test a canadian cross?
>>
>
> Andreas, I think we could remove all the runtime checks and only rely
> on the compile time checks of the CLooG version. ÂWhat do you think?
>
The runtime checks are disabled, if we're cross-compiling.
There are scenarios where the runtime checks are useful.
So as long as they don't break anything I would leave them in.
However i'm not an expert in writing configure scripts ;-)
So, if it helps the acceptance of this patch, I will remove the runtime
checks. :-)
I did not test a canadian cross, just added the bypass for the runtime
check in case of cross-compilation.
> Thanks,
> Sebastian
>
Thanks for the reviews,
Andreas