This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Ping: [PATCH] Support official CLooG.org versions.
- From: Sebastian Pop <sebpop at gmail dot com>
- To: DJ Delorie <dj at redhat dot com>
- Cc: Ralf dot Wildenhues at gmx dot de, simbuerg at googlemail dot com, gcc-graphite at googlegroups dot com, gcc-patches at gcc dot gnu dot org, bonzini at gnu dot org, neroden at gcc dot gnu dot org, aoliva at redhat dot com
- Date: Wed, 27 Oct 2010 21:59:06 -0500
- Subject: Re: Ping: [PATCH] Support official CLooG.org versions.
- References: <AANLkTim5Z09seG+mkQ+NuHR=wGgH7dq2zg+c0qoq6GtS@mail.gmail.com> <201010272035.o9RKZXC8024390@greed.delorie.com>
Hi,
thanks for the review.
On Wed, Oct 27, 2010 at 15:35, DJ Delorie <dj@redhat.com> wrote:
>
>> (now in CC) review this patch?
>> http://gcc.gnu.org/ml/gcc-patches/2010-10/msg00673.html
>
> Aside from Ralf's concerns, I add...
>
> The GPL notice requires a version number, and preferably the "or any
> later version" variant.
Andreas, could you please update the text at the beginning of cloog.m4
with the following notice:
#This file is part of GCC.
#GCC is free software; you can redistribute it and/or modify it under
#the terms of the GNU General Public License as published by the Free
#Software Foundation; either version 3, or (at your option) any later
#version.
#GCC is distributed in the hope that it will be useful, but WITHOUT
#ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
#FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
#for more details.
#You should have received a copy of the GNU General Public License
#along with GCC; see the file COPYING3. If not see
#<http://www.gnu.org/licenses/>.
>
> "Runtime" checks should be avoided as they won't work when you're
> cross-compiling. ?Did you test a canadian cross?
>
Andreas, I think we could remove all the runtime checks and only rely
on the compile time checks of the CLooG version. What do you think?
Thanks,
Sebastian