This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Vector subscription patch


On Fri, 22 Oct 2010, Artem Shinkarov wrote:

> Ok, so here is the same patch with fixed error messages and changelog.
> All the optimizing issues we should bring in the separate patch on the
> level of middle-end.
> 
> ChangeLog:
> 
> 2010-10-20  Artjoms Sinkarovs <artyom.shinakroff@gmail.com>
>     Andrew Pinski <pinskia@gmail.com>
> 
>     gcc/
>     * c-typeck.c (build_array_ref): Handle subscripting of vectors.
> 
>     gcc/c-family/
>     * c-common.h (c_common_mark_addressable_vec): Declare.
>     * c-common.c (c_common_mark_addressable_vec): New function.
> 
>     gcc/testsuite/
>     * gcc.c-torture/execute/vector-subscript-1.c: Likewise.
>     * gcc.c-torture/execute/vector-subscript-2.c: Likewise.
>     * gcc.c-torture/execute/vector-subscript-3.c: New testcase.
>     * gcc.dg/vector-subscript-1.c: Likewise.
>     * gcc.dg/vector-subscript-2.c: Likewise.
>     * gcc.dg/vector-subscript-3.c: New testcase.
>     * gcc.dg/array-8.c: Adjust.
> 
>     gcc/doc/
>     * extend.texi: New paragraph

gcc/doc doesn't have its own ChangeLog; you should have a log entry for 
doc/extend.texi in gcc/ChangeLog.  This entry should be more meaningful, 
giving some indication of what has changed, e.g. "Document subscripting 
vectors." rather than just "New paragraph".

The patch is OK with that ChangeLog fix.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]