This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: 0002-Fix-32-bit-alignment for Core i7


On Tue, Oct 19, 2010 at 7:17 PM, Jan Hubicka <hubicka@ucw.cz> wrote:
>> This patch adjusts alignment for Core i7 32-bit ABI. ?This speeds up
>> SPECfp by 0.4% and SPECint by 0.2% in 32-bit mode.
>>
>> Tested by bootstrapping on i686-pc-linux-gnu.
>>
>> OK to commit?
>>
>> Thank you,
>>
>> --
>> Maxim Kuvyrkov
>> CodeSourcery
>> maxim@codesourcery.com
>> (650) 331-3385 x724
>
>> 2010-10-19 ?Bernd Schmidt ?<bernds@codesourcery.com>
>> ? ? ? ? ? Maxim Kuvyrkov ?<maxim@codesourcery.com>
>>
>> ? ? ? Tune alignment for Intel Core i7
>>
>> ? ? ? * config/i386.h (TARGET_COREI7{_32,_64,}): New macros.
>> ? ? ? (enum processor_type): Update comment. ?Add entries for Core i7.
>> ? ? ? * config/i386-c.c (ix86_target_macros_internal): Update.
>> ? ? ? * config/i386.c (m_COREI7{_32,_64}): New macros.
>> ? ? ? (m_GENERIC32, m_GENERIC64): Use generic tuning for Core i7.
>> ? ? ? (processor_target_table): Tune alignment for Core i7.
>>
>> ? ? ? * doc/invoke.texi: Document "corei7" option value.
>
> I am bit confused with the split of patches. I would expect the __corei7__
> define and manual to come in the previous patch.. ?The alignment changes are
> OK.
>
> I would like to see the naming issue Andi pointed out discussed a bit.
> Traditionally naming x86 CPUs is a major mess. ?Otherwise the first patch
> seems sane, too.
>

There is no good solution for this. -mtune=corei7 is as good as
we can get.



-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]