Re: [patch, fortran] PR46079 ABI for empty stop statement broken

[Jerry DeLisle <jvdelisle at frontier dot com>]

On 10/19/2010 12:45 PM, Mikael Morin wrote:
> On Tuesday 19 October 2010 04:45:05 Jerry DeLisle wrote:
> > Hi,
> >
> > I discovered this minor bug while testing for the revamp of the type
> > enumerators.
> >
> > I think the ChangeLog is clear enough.
> >
> > Regression tested on x86-64-linux-gnu. No new test case needed.
> >
> > OK for trunk?
> >
> > Jerry
> >
> > 2010-10-18  Jerry DeLisle<jvdelisle@gcc.gnu.org>
> >
> > 	PR fortran/46079
> > 	* trans_stmt.c (gfc_trans_stop): If the STOP statement is empty,
> > 	build a call to the new function stop_empty.  If integer, build a call
> > 	to stop_string or error_stop_string with a NULL pointer and the
> > 	integer value as the length.
> > 	* trans.h: Add declaration for gfor_fndecl_stop_empty.
> > 	* trans-decl.c (gfc_build_builtin_function_decls): Build declaration
> > 	for stop_empty.
> >
> > 2010-10-18  Jerry DeLisle<jvdelisle@gcc.gnu.org>
> >
> > 	PR libgfortran/46079
> > 	* runtime/stop.c (stop_empty): New function. (stop_numeric): Restore
> > 	to previous behavior. (stop_string, error_stop_string): Use string
> > 	pointer to signal emitting numeric only.  Use string length as the
> > 	stop code.
>
> Let's keep error_stop_string care about strings only. (Please!)
Thanks for bringing this up.  It was bothering me too  I will gladly do this 
diffently and will re-submit the patch.

Jerry