This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix ifcvt ICE
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: "Chung-Lin Tang" <cltang at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 13 Oct 2010 09:51:19 +0200
- Subject: Re: [PATCH] Fix ifcvt ICE
- References: <4CB34E16.3020804@codesourcery.com>
> So this patch is quite simple: implement two replacement functions
> find_active_insn_before/after() that correct the above mentioned
> behavior, and use them in ifcvt.
OK on principle, but the implementation isn't fully correct because it uses
BLOCK_FOR_INSN and this isn't defined for BARRIERs.
Please add a BB parameter to both functions and test against BB_HEAD or BB_END
to stop the iteration, like in first_active_insn/last_active_insn.
--
Eric Botcazou