This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: predicate aware uninitialized variable analysis
- From: Andrew Pinski <pinskia at gmail dot com>
- To: Xinliang David Li <davidxl at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Guenther <richard dot guenther at gmail dot com>
- Date: Tue, 12 Oct 2010 12:18:41 +0700
- Subject: Re: predicate aware uninitialized variable analysis
- References: <522e93240907221419y2d8dbdbdta7343148338688cc@mail.gmail.com> <q2r522e93241004131223scbd7cc8fx283be7d728f7ef58@mail.gmail.com> <h2k84fc9c001004140344of207d33av33ab3a99e58d9fdd@mail.gmail.com> <s2u522e93241004211743wda41437cife4d07d975e1a631@mail.gmail.com> <AANLkTikLt7HgxyvLf_=HF8erhf5hx7YAC3-bLvo_k4P8@mail.gmail.com> <AANLkTikLw33hV9SSMwsn7BLyZAPZ6niqF4dcx3k+y-F4@mail.gmail.com>
On Tue, Oct 12, 2010 at 11:46 AM, Xinliang David Li <davidxl@google.com> wrote:
> Please review the patch attached. The number of operand of the phi
> exceeds the width of the bit vector (fixed length for efficiency)
> leading to the ICE later.
>
> OK to checkin after test is done?
I think this is the incorrect patch. If it is a bit vector, then it
should be sizeof (unsigned) * BITS_PER_UNIT. And most likely should
use HOST_FASTEST_WIDEST_INT instead.
Thanks,
Andrew Pinski