This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fix ppc-vxworks build failure on vxlib-tls for RTPs


Hi Nathan,

Nathan Sidwell wrote:
> >       * config/rs6000/vxworks.h (TARGET_OS_CPP_BUILTINS): Call
> >       VXWORKS_OS_CPP_BUILTINS.
 
> ok, thanks

 Further experiments uncovered a couple of glitches related to this change:

 1) The common VXWORKS_OS_CPP_BUILTINS has

      builtin_define ("__vxworks");                                     \
      builtin_define ("__VXWORKS__");                                   \

    so these are not needed any more in the rs6000 TARGET_OS version. They really are
    not rs6000 specific so would better be deleted from the latter.

 2) config/vxworksae.h misses VXWORKS_OS_CPP_BUILTINS, so the build fails for this
    target now. It probably would have failed for all the other (! ppc) targets before
    the change.

 This patches fixes that. We verified that our test results are still nominal on
 ppc-vxworks, and that we can build and get good test results on vxworksae as well.

 OK ?

 Thanks in advance,

 Olivier

        * config/vxworksae.h: Add missing VXWORKS_OS_CPP_BUILTINS.
        * config/rs6000/vxworks.h: Remove redondant cpp builtin definitions.
 

Attachment: vxae.dif
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]