This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add -print-lto-plugin


On 03/10/2010 11:05, Andi Kleen wrote:
> Good point that the option makes sense on non Unix.
> 
>>   So I'd be in favour of adding this option, but not in it's current shape:
>> I'd like the code behind it to determine shared lib prefix and suffix
>> correctly for the platform.
> 
> The new code uses the exact same method as the rest of gcc.c, which
> hard codes the file name.

  That's a *bad* thing, not a good one!

> If you add some other method presumably my code could be converted
> at the same time.

  I guess I just have an instinctive reaction against copy-pasting badness
into extra places than it already exists.  At least it's in the same C file so
I won't be all that likely to miss it.

> But I don't think it makes sense to delay it for something that
> doesn't exist today.

  Well, I see your point about not wanting to hardcode the plugin name into
makefiles.

    cheers,
      DaveK


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]