This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: MN10300: Fix frame related notes and unwind info
- From: Richard Henderson <rth at redhat dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: law at redhat dot com, aoliva at redhat dot com, gcc-patches at gcc dot gnu dot org
- Date: Fri, 01 Oct 2010 10:07:14 -0700
- Subject: Re: RFA: MN10300: Fix frame related notes and unwind info
- References: <m3fwwqmbby.fsf@redhat.com>
On 10/01/2010 03:55 AM, Nick Clifton wrote:
> + emit_insn (F (gen_addsi3 (stack_pointer_rtx,
> + stack_pointer_rtx,
> + GEN_INT (-4 * num_regs_to_save))));
F and emit_insn are improperly nested here and several following places.
> - emit_insn (gen_movsi (gen_rtx_REG (SImode, i),
> - gen_rtx_MEM (SImode, addr)));
> + emit_insn (gen_movsf (gen_rtx_REG (SFmode, i),
> + gen_rtx_MEM (SFmode, addr)));
Forgot to mark with F?
Consider marking the epilogue as well, though usually that's
not as simple as setting RTX_FRAME_RELATED_P. You generally
have to use most of the REG_CFA_* specific notes too.
> +static enum unwind_info_type
> +mn10300_except_unwind_info (void)
> +{
> + return UI_SJLJ;
> +}
Please use the generic sjlj_except_unwind_info.
> +#define DWARF2_UNWIND_INFO 0
Unneeded. This will be poisoned when all targets define
TARGET_EXCEPT_UNWIND_INFO.
r~