Re: [Patch, Fortran] PR fortran/45776: More variable definition checks

[Daniel Kraft <d at domob dot eu>]

Daniel Kraft wrote:
> And another update.  The last patch segfaulted for INQUIRE with 
> transfers, because in this case code->ext.dt was NULL.  I added a check 
> for that, since this is also not "reading".  Changed is only the 
> resolve_transfer part (and I regard the change as trivial).
>
> Starting a new regtest now ;)  Ok if successful?

No failures this time on x86_64-unknown-linux-gnu.

> Yours,
> Daniel
>
> Daniel Kraft wrote:
> > Here's an updated patch with the suggestions and IRC discussion 
> > incorporated -- earlier than I expected, but anyways ;)
> >
> > What do you think about the new solution?  I will run a fresh regtest 
> > tomorrow, but at least the io_*, write_*, read_* and namelist_* tests 
> > seem to pass.  Ok?
> >
> > Yours,
> > Daniel
> >
> > Daniel Kraft wrote:
> > > Hi,
> > >
> > > the attached patch implements the missing IO related variable 
> > > definition checks (which is now PR 45776).  Except the LOCK/UNLOCK 
> > > cases which can not yet be implemented because locks are not yet in 
> > > gfortran, the full list of variable definition contexts of F2008, 
> > > 16.6.7 should be implemented with that.
> > >
> > > It fixes some accepts-invalid cases that my last patch created, but 
> > > also adds some checks that were missing before it.  As a bonus, it 
> > > adds a F2008 check when using NEWUNIT (which was missing before).
> > >
> > > As I'm not really familiar with the IO related data-structures, I 
> > > left two XXX comments in the patch asking for possible better 
> > > solutions (when they exist), please take a look at them.
> > >
> > > Regression testing on GNU/Linux-x86-32.  Ok for trunk if no failures?


--
http://www.pro-vegan.info/
--
Done:  Arc-Bar-Cav-Kni-Ran-Rog-Sam-Tou-Val-Wiz
To go: Hea-Mon-Pri