This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: gengtype improvements for plugins, thirdround! patch 5/7 [typedopt]
On Thu, Sep 23, 2010 at 4:14 PM, Diego Novillo <dnovillo@google.com> wrote:
> On Thu, Sep 23, 2010 at 10:07, Basile Starynkevitch
> <basile@starynkevitch.net> wrote:
>
>> However, I believe that gengtype is misindented from the start, and
>> this explains most of my indentation issues. Please read
>> http://gcc.gnu.org/ml/gcc/2010-09/msg00448.html for details.
>
> If gengtype is misindented, please submit a separate patch fixing
> indentation issues. ?Don't mix the two things in one patch. ?Your
> changes are sufficiently big already.
And note that using GNU indent is not going to produce something
that is free of indentation issues.
Usual practice is to fix indentation issues in the code snippets you
are changing anyway.
Richard.