This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch v2] convert config/vms/*crt0* files to gcc style (PR 44242)


On 09/22/2010 04:02 AM, Tristan Gingold wrote:
> Richard, you have traditionally approved the VMS patches so I have
> CC'ed you.  However, if the SC think the VMS files deserve a
> maintainer, I (and/or Doug Rupp) will be happy to become maintainers
> for the VMS specific parts.

I do think one of you should become VMS maintainer.

>> -  char **argv;
>> -  char **envp;
>> -
>> -#pragma __pointer_size long
>> -
>> -  int i;
>> -  char **long_argv;
>> -  char **long_envp;
...
>> +  int argc;
>> +  int argv;
>> +  int envp;
>> +  int status;
>> +  int i;
>> +  long long *long_argv;
>> +  long long *long_envp;

It would make much more sense to me if you were to use __attribute__((mode()))
to change pointer sizes, rather than just casting between integer types.

In particular, that would get you extension via ADDP4 on ia64, which surely is
More Correct.  It may so happen that vms is not using ia64 segmentation, but it
feels wrong to ignore it entirely.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]