This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [MIPS][LS3A]Generic Support
"Joseph S. Myers" <joseph@codesourcery.com> writes:
> On Fri, 17 Sep 2010, Mingming Sun wrote:
>> This patch adds generic support for Loongson 3A CPU such as -march and
>> mtune options.
Thanks for the patch. In addition to Joseph's comments:
> The following is mostly a generic response that applies to any addition of
> support for a new CPU for MIPS or many other processors:
>
> * The known CPU names are documented in doc/invoke.texi, your patch needs
> to update that file.
>
> * You need to add costs data in the right place in mips_rtx_cost_data.
>
> * -march options are passed to the assembler so you need a corresponding
> binutils patch as well to avoid getting assembler errors/warnings on every
> compilation.
I think this is big enough to require a copyright assignment, especially
after the mips_rtx_cost_data change that Joseph mentions. Do you have
an assignment on file?
It might be worth adding a generic TARGET_LOONGSON macro, rather than
having to test TARGET_LOONGSON_2EF || TARGET_LOONGSON_3A.
Richard