This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: gengtype improvements for plugins, completed! patch 6/N [wstate]
2010/9/14 Basile Starynkevitch <basile@starynkevitch.net>:
> The -d option for debug dump triggers the do_dump flag that you
> introduced previously, and I did not change much about it. However, I
> am now calling your dump_everything() function at several places. It
> can be used by gengtype users to understand and debug the internal
> gengtype data.
>
> What do you want to drop and why?
The gtype.state file is a human-readable text. So is the debug dump,
and they contain similar, if not the same, information. My question
is, does gtype.state include everything that a debug dump has?
Because, if yes, I don't see any reason to keep debug dump facility
and just use gtype.state in its place. Hopefully I am clearer now :)
>> +static struct state_token_st *
>> +read_a_state_token (void)
>>
>> Can you break up this function to several smaller ones?
>
> Why? ÂIt is a fairly standard lexer.
Yes it is. Fair enough then.
--
Laurynas