This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Modify TER to not propagate expressions across call
On Mon, Sep 13, 2010 at 12:53 PM, Michael Matz <matz@suse.de> wrote:
> Hi,
>
> On Sat, 11 Sep 2010, Richard Guenther wrote:
>
>> On Fri, Sep 10, 2010 at 10:10 PM, Pat Haugen
>> <pthaugen@linux.vnet.ibm.com> wrote:
>> > ?The following patch tries to limit TER such that it will not propagate
>> > expressions across calls, which can extend lifetimes across calls and result
>> > in suboptimal code due to additional save/restore of registers. I tried
>> > allowing just BUILT_IN_MD builtins to be bypassed, but that still didn't
>> > catch things like sqrt/powf which were seen in 435.gromacs benchmark, so
>> > resorted to all builtins (no worse than what was being done before).
>> >
>> > Bootstrap/regtested on powerpc64-linux with no new regressions. ?OK for
>> > mainline?
>>
>> Hm - I think we are not restricting TER to work inside basic-blocks.
>
> We do.
Ok, with two people confirming this the original patch looks ok to me.
Thanks,
Richard.