Re: gengtype improvements for plugins, completed! patch 1/N [declprog]

[Basile Starynkevitch <basile at starynkevitch dot net>]

On Thu, Sep 09, 2010 at 03:02:10PM +0200, Paolo Bonzini wrote:
> On 09/09/2010 08:07 AM, Basile Starynkevitch wrote:
> >I still don't understand who has a reviewer hat
> 
> Everybody can informally review patches, including you.
> 
> Instead, what MAINTAINERS tell you is who approve patches;
> "maintainers" do not need external reviews, "reviewers" do.  Maybe
> "committers" and "maintainers" could be a better choice of words,
> but that's too late now to change it.
> 
> There are 2*2 possible scenarios which involve reviews from people
> not in MAINTAINERS:

Thanks for the explanation!
[....]
> 
> 
> To some up, usually you should pay more attention to bad news than
> to good news if you want your patches to go in. :)

I try hard to follow the bad news.


> 
> Also, for patch series as big as this one you should really, really
> learn quilt or git.  (I wrote my own simplified version of quilt,
> but I was a student when I did...).


I will continue sending the patch series "completed!" but I am not at
all ignoring the comments gotten so far. after I end sending this
"completed!" series, I will send again a "third round" serie of
patches, taking into account every comment recieved so far.

Regarding formatting & indentation issues, Jeremie Salvucci, when he
typed code, had a non GNU-conformant .emacs (while I Basile hopefully
do have a GNU conformant .emacs file).  This explains the many
indentation issues.  But I am the only one to be blamed.  Jeremie was
my intern, and I made the mistake to not noticing that his .emacs was
not conformant to GCC rules, and to not correcting Jeremie's coding
habits while he was typing with me.  So please blame me Basile, not
him Jeremie!

Regarding my next serie of patches - the incoming third round - I
would like very much to get a concrete advice regarding quilt
use. Paolo, what concrete procedure do you suggest? I was thinking of
starting from a more recent trunk, apply each patch I am sending in
this second round "complete!" serie, re-reading them manually,
re-indenting with Emacs with correct setting, and of course re-reading
all the comments we got so far. But I miss how to concretely use quilt
in that case.  Or do you think it is too late to use quilt?

Cheers.


-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mines, sont seulement les miennes} ***