This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: gengtype improvements for plugins, completed! patch 2/N [verbosity]
On Wed, 08 Sep 2010 22:02:01 +0200
Bernd Schmidt <bernds@codesourcery.com> wrote:
> On 09/08/2010 07:51 PM, Basile Starynkevitch wrote:
> > + {
> > + DBGPRINTF ("set_gc_used p %p '%s' nbvars %d", (void*) p, p->name, nbvars);
> > set_gc_used_type (p->type, GC_USED, NULL);
> > + nbvars++;
> > + };
>
> Are you using "diff -b"? If yes - please don't. If no, this patch
> breaks formatting. Also, no semicolon after closing brace.
Yes I did use diff -b. I believe my file contain tab characters inserted by Emacs. Do you suggest untabifying it before diffing?
What is the correct command to make a relative patch. I have a directory containing the previous version. I am not using quilt or git. Just plain old GNU diff.
> Patch 1/N introduces many instances of nonstandard formatting. Please
> fix it to conform to gcc coding standards.
I did read it several times before sending, but I confess not knowing all the details, or perhaps I misunderstood some. Could you help me a little bit by showing a few non conformities?
Thanks for the comments.
And are you suggesting that once the typos are fixed, the patch is OK? Sadly, I did not understand your reply that way. What other fixes should I work on?
Cheers.
--
Basile STARYNKEVITCH http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***