This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: ARM: More reorganization of extend patterns (PR43137)
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Bernd Schmidt <bernds at codesourcery dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 01 Sep 2010 16:52:14 +0100
- Subject: Re: ARM: More reorganization of extend patterns (PR43137)
- References: <4C3C383E.8060604@codesourcery.com>
On Tue, 2010-07-13 at 10:56 +0100, Bernd Schmidt wrote:
> This patch merges a number of different extend:DI patterns by using a
> QHSI mode_iterator. It also removes separate patterns from thumb2.md
> as
> we can just set attr ce_count for ARM patterns as well. I've
> completed
> what I'd partially done in my previous patch, which is to remove
> unnecessary constant pool handling from these patterns - none of them
> accept constants.
>
> To fix PR43137, I've added splitters that run before the subreg2 pass.
> In general, the ARM backend makes practically no use of lower-subreg;
> I
> have given up on fixing that for the moment as it was more effort than
> I
> can spare right now. Just doing it for these patterns is enough to be
> a
> win in certain cases.
>
> Regression tested (together with other patches) on
> qemu-system-armv7/arch=armv7-a/thumb
> qemu-system-armv7/thumb
> qemu-system-armv7
>
> Ok?
>
The define_mode_attrs need to be moved to iterators.md. Also, a number
of patterns have been changed (inconsistently with the rest of arm.md)
to not have the terminating ')' in column 1.
Otherwise, OK.
R.