This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, Fortran, OOP] PR 42769: ICE in resolve_typebound_procedure


>> Ok for trunk?
>
> OK, though I wonder whether
>
> + ?/* Make sure the vtab has been generated. ?*/
> + ?vtab = gfc_find_derived_vtab (derived);
>
>
> will not lead to an assigned-but-not-used warning?

I didn't see a warning (not having done a full bootstrap), but ...


> Wouldn't a simple
>
> + ?gfc_find_derived_vtab (derived);
>
> be sufficient?

... of course you are right that this is sufficient. I have committed
the corrected patch as r163631.

Thanks for the review,
Janus



>> 2010-08-29 ?Janus Weil<janus@gcc.gnu.org>
>>
>> ? ? ? ?PR fortran/42769
>> ? ? ? ?* resolve.c (resolve_structure_cons): For derived types, make sure
>> the
>> ? ? ? ?type has been resolved.
>> ? ? ? ?(resolve_typebound_procedures): Make sure the vtab has been
>> generated.
>>
>>
>> 2010-08-29 ?Janus Weil<janus@gcc.gnu.org>
>>
>> ? ? ? ?PR fortran/42769
>> ? ? ? ?* gfortran.dg/dynamic_dispatch_11.f03: New.
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]