Re: [Patch ARM] Refactor neon-schedgen.ml and regenerate A8 neon descriptions.

[Julian Brown <julian at codesourcery dot com>]

On Fri, 27 Aug 2010 08:22:51 +0100
Ramana Radhakrishnan <ramana.radhakrishnan@arm.com> wrote:

> 
> On Wed, 2010-08-25 at 14:53 +0100, Julian Brown wrote:
> 
> > 
> > I think it looks generally OK apart from the indendation on the
> > functions coreStr and tuneStr, looking again.
> 
> This is the final patch after the changes.
> 
> Ok to commit ? 

I noticed one more thing: at the risk of putting you off O'Caml for
life, you should probably be using structural equality (=) not physical
equality (==) here:

 let filter_core = List.filter (fun (_, _, _, cores) 
 				   -> List.exists ((==) core) cores)

You're getting away with it because you happen to be testing against
the exact same string (i.e. pointer). Consider this though:

# let a = "foo";;
val a : string = "foo"
# let b = "foo";;
val b : string = "foo"
# a==b;;
- : bool = false
# a=b;;
- : bool = true

(I can't actually approve the patch, FWIW.)

Cheers,

Julian