Re: [PATCH] PR debug/42487, xfail scan-assembler on DW_AT_ranges in gcc.dg/debug/dwarf2/aranges-fnsec-1.c for darwin

[Richard Henderson <rth at redhat dot com>]

On 08/17/2010 08:16 AM, Jack Howarth wrote:
> On Tue, Aug 17, 2010 at 08:08:05AM -0700, Mark Mitchell wrote:
>> Richard Henderson wrote:
>>>> +/* { dg-final { scan-assembler "DW_AT_ranges" { xfail *-*-darwin* } } } */
>>>
>>> You should use a dg-skip-if.  The other two tests *should* be failing,
>>> but don't because the regexp's incorrectly use a "." unconditionally.
>>
>> And we shouldn't be adding more xfail's for specific operating systems,
>> unless absolutely necessary.  If the issue here is that we don't have
>> -function-sections, then presumably the test will fail on all targets
>> with that characteristic, and we should use the "effective target"
>> machinery to guard the test.
> 
> Richard,
>    This patch has been superseded by http://gcc.gnu.org/ml/gcc-patches/2010-08/msg01218.html
> based on Richard Henderson's comments. Can you review that one instead?

Well, that new patch is what I asked for, but Mark is asking for
something more.  In gcc/testsuite/lib/target-supports-dg.exp, add
a proc dg-require-function-sections, then add a line

  { dg-require function-sections }

to the testcase.

I'm not sure how to test for function sections for Darwin.  
Ordinarily I would think you would look for an error message from
the compiler, but for some reason Darwin doesn't generate one 
and yet still fails to actually use function sections.

Probably what you'll want to do is match the target_triplet in
there.  See dg-require-dll.


r~