This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR debug/42487, xfail scan-assembler on DW_AT_ranges in gcc.dg/debug/dwarf2/aranges-fnsec-1.c for darwin
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Richard Henderson <rth at redhat dot com>
- Cc: Jack Howarth <howarth at bromo dot med dot uc dot edu>, gcc-patches at gcc dot gnu dot org, mikestump at comcast dot net
- Date: Tue, 17 Aug 2010 08:08:05 -0700
- Subject: Re: [PATCH] PR debug/42487, xfail scan-assembler on DW_AT_ranges in gcc.dg/debug/dwarf2/aranges-fnsec-1.c for darwin
- References: <20100816233214.GA16983@bromo.med.uc.edu> <4C69CB1B.2000903@redhat.com>
Richard Henderson wrote:
>> +/* { dg-final { scan-assembler "DW_AT_ranges" { xfail *-*-darwin* } } } */
>
> You should use a dg-skip-if. The other two tests *should* be failing,
> but don't because the regexp's incorrectly use a "." unconditionally.
And we shouldn't be adding more xfail's for specific operating systems,
unless absolutely necessary. If the issue here is that we don't have
-function-sections, then presumably the test will fail on all targets
with that characteristic, and we should use the "effective target"
machinery to guard the test.
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713