This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [Patch ARM] Fix PR45070 - Miscompiled c++ class with packed attribute on ARM with -Os optimizations


Joseph S. Myers writes:
> I don't see anything ARM-specific about this testcase at all.  Why
> isn't
> it going in gcc.c-torture/execute, with no special dg-* markings, where
> it
> will be run for all targets with a range of options that includes -Os?
> gcc.target is only for tests that are target-specific in some way or
> where
> special target-specific options are needed to exercise the bug in
> question, not for target-independent tests that show the bug with
> options
> that are among those c-torture uses.

I figured it was an ARM-specific regression test because the bug was
ARM-specific, but I can see the value of running this test for other
targets and at other compilation levels, to find existing or new
bugs elsewhere.

I've updated the patch and reattached it.  Third time's a charm? ;-)

Cheers,
Ian


2010-08-12  Ian Bolton  <ian.bolton@arm.com>

	* config/arm/arm.c (arm_output_epilogue): Ensure that return value
	of size 1-3 is handled correctly.
	* testsuite/gcc.c-torture/execute/pr45070.c: New test.

Attachment: pr45070.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]