This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Hookize TARGET_ASM_OUTPUT_ADDR_CONST_EXTRA
- From: dominiq at lps dot ens dot fr (Dominique Dhumieres)
- To: gcc-patches at gcc dot gnu dot org
- Cc: aesok at post dot ru
- Date: Sat, 07 Aug 2010 12:30:13 +0200
- Subject: Re: [PATCH] Hookize TARGET_ASM_OUTPUT_ADDR_CONST_EXTRA
> This patch turns TARGET_ASM_OUTPUT_ADDR_CONST_EXTRA macro into a hook.
>
> The patch has been bootstrapped on and regression tested on
> x86_64-unknown-linux-gnu for c and c++.
Athough I don't understand anything about the hook changes I find
quite wierd that it is tested on x86_64-unknown-linux-gnu only
and not on other platforms and that OUTPUT_ADDR_CONST_EXTRA is
removed on config/i386/ only. A grep for OUTPUT_ADDR_CONST_EXTRA
on gcc/config/* returns
gcc/config/arm/arm.h:#define OUTPUT_ADDR_CONST_EXTRA(file, x, fail) \
gcc/config/cris/cris.c:/* Worker function for OUTPUT_ADDR_CONST_EXTRA. */
gcc/config/cris/cris.h:#define OUTPUT_ADDR_CONST_EXTRA(STREAM, X, FAIL) \
gcc/config/i386/i386.h:#define OUTPUT_ADDR_CONST_EXTRA(FILE, X, FAIL) \
gcc/config/m68k/m68k.c:/* m68k implementation of OUTPUT_ADDR_CONST_EXTRA. */
gcc/config/m68k/m68k.h:#define OUTPUT_ADDR_CONST_EXTRA(FILE, X, FAIL) \
gcc/config/mn10300/mn10300.h:#define OUTPUT_ADDR_CONST_EXTRA(STREAM, X, FAIL) \
gcc/config/rs6000/rs6000.c:/* Implement OUTPUT_ADDR_CONST_EXTRA for address X. */
gcc/config/rs6000/rs6000.h:#define OUTPUT_ADDR_CONST_EXTRA(STREAM, X, FAIL) \
gcc/config/s390/s390.h:#define OUTPUT_ADDR_CONST_EXTRA(FILE, X, FAIL) \
gcc/config/sh/sh.h:#define OUTPUT_ADDR_CONST_EXTRA(STREAM, X, FAIL) \
gcc/config/v850/v850.h:#define OUTPUT_ADDR_CONST_EXTRA(FILE, X, FAIL) \
gcc/config/xtensa/xtensa.h:#define OUTPUT_ADDR_CONST_EXTRA(STREAM, X, FAIL) \
I am quite surprised that OUTPUT_ADDR_CONST_EXTRA is not removed
also for the non i386 platforms. Am I wrong?
Cheers
Dominique