This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] Use gfc_symbol_state.


Le 04.08.2010 10:55, Daniel Kraft a Ãcrit :

Mikael Morin wrote:
Hello,

this implements an idea from Janus, to use gfc_symbol_state instead of
gcc_assert (changed_syms == NULL).

While at it, the patch also modifies gfc_symbol_state as follows :
- It changes the conditional internal error into a gcc_assert, as the
error message was not very helpful to a non-gfortran-developer.
- the gcc_assert also handles the #if GFC_DEBUG condition better, as
it is enabled/disabled by configure (--enable-checking), documented,
etc. So the #if GFC_DEBUG conditions are removed . Probably nobody was
enabling it.
- the function is renamed into something more descriptive
(gfc_symbol_state->gfc_enforce_clean_symbol_state)

Regression tested on x86_64-unknown-freebsd8.0. OK for trunk ?

Ok. Thanks for the patch!


Daniel

Committed at revision 162865. Thanks

Mikael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]