This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch, Fortran] Fix dependency checking regression for 64-bit

From: Tobias Burnus <burnus at net-b dot de>
To: Thomas Koenig <tkoenig at netcologne dot de>
Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Tue, 03 Aug 2010 23:24:18 +0200
Subject: Re: [patch, Fortran] Fix dependency checking regression for 64-bit
References: <1280853926.25237.8.camel@linux-fd1f.site>

Thomas Koenig wrote:

Regression-tested on x86_64-unknown-linux-gnu.  OK?  Also OK for 4.5 if
we need it?  (I haven't checked yet).

The actual patch looks fine, however, the test case looks incomplete: No reference to the PR - and it is completely unclear what you are testing for - and ICE? Or for dependencies - if the latter, then you miss a check for that! OK if you fix the testcase.

Tobias

2010-08-03 Thomas Koenig<tkoenig@gcc.gnu.org>

	PR fortran/45159
	* dependency.c (gfc_deb_compare_expr):  Remove any integer
	conversion functions to larger types from both arguments.
	Remove handling these functions futher down.

2010-08-03 Thomas Koenig<tkoenig@gcc.gnu.org>

	PR fortran/45159
	* gfortran.dg/dependency_30.f90:  New test.

Follow-Ups:
- Re: [patch, Fortran] Fix dependency checking regression for 64-bit
  - From: Thomas Koenig

References:
- [patch, Fortran] Fix dependency checking regression for 64-bit
  - From: Thomas Koenig

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]