This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, ARM] Fix PR45094


In message <20100801083614.GA2569@qiyaows>
          Yao Qi <yao@codesourcery.com> wrote:

> This patch fixes generated wrong instructions reported in PR45094,
> which is caused by typo.
> 
> Tested on arm-unknown-linux-gnueabi, fixes the new test.
> [...]

> Index: config/arm/arm.c
> ===================================================================
> --- config/arm/arm.c	(revision 162792)
> +++ config/arm/arm.c	(working copy)
> @@ -12570,13 +12570,13 @@
>  	    {
>  	      if (GET_CODE (XEXP (operands[0], 0)) == PRE_MODIFY)
>  		{
> -		  output_asm_insn ("ldr%?\t%0, [%1, %2]!", otherops);
> -		  output_asm_insn ("ldr%?\t%H0, [%1, #4]", otherops);
> +		  output_asm_insn ("str%?\t%0, [%1, %2]!", otherops);
> +		  output_asm_insn ("strr%?\t%H0, [%1, #4]", otherops);
                                      ^^^

Typo (one 'r') ?

>  		}
>  	      else
>  		{
> -		  output_asm_insn ("ldr%?\t%H0, [%1, #4]", otherops);
> -		  output_asm_insn ("ldr%?\t%0, [%1], %2", otherops);
> +		  output_asm_insn ("str%?\t%H0, [%1, #4]", otherops);
> +		  output_asm_insn ("str%?\t%0, [%1], %2", otherops);
>  		}
>  	    }
>  	  else if (GET_CODE (XEXP (operands[0], 0)) == PRE_MODIFY)

John.
-- 
John Tytgat, in his comfy chair at home
John.Tytgat@aaug.net


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]