This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ifcvt/crossjump patch: Fix PR 42496, 21803


On 07/27/10 16:28, Eric Botcazou wrote:
BTW, this is essentially the same thing that's done in the main loop in
ifcvt.c (do you also see it as a kludge there?), where I originally
implemented this optimization, and you were the one who suggested I move
it to cfgcleanup.c.  Maybe you misunderstood the optimization back then
and thought it was just CFG manipulation?  That's simply not the case;
the analogy with crossjumping doesn't entirely hold.
Yes, I still think that it will be more useful in cfgcleanup.c.
While I don't think head merging is a perfect fit for cfgcleanup.c, I don't think it's worth a huge argument. I'll go along with the final version (whatever it looks like) in cfgcleanup.c

  And it's
another form of code commonization so I still think that implementing it using
CFG manipulations is the best approach.
I think this is the root of the disagreement. I'll keep looking at it.


Please run this by another maintainer though.
I'll own reviewing.

Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]