This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, fortran] [4.4/4.5/4.6 regression] ICE in resolve_equivalence


Le 25.07.2010 17:55, Tobias Burnus a Ãcrit :

Mikael Morin wrote:
There is no testcase as the ones in the pr were not giving any ICE on
my platform. I can add them if someone prefers. I have checked that
the valgrind errors are gone for both of them anyway.

Regression tested on x86_64-unknown-freebsd8.0. OK for trunk/4.5/4.4 ?

I need release manager approval for accelerated commit on 4.5 (if not
too late).

OK. (In general, I prefer test cases, however, for this PR, I do not feel strong about it.)
Committed (without testcase) as revision 162516.

The question is whether such a memory problem (access to freed memory) can be caught by the testsuite (maybe with valgrind-checking enabled?). If so, then it makes sense to add a testcase, even if a normal build would not notice a regression there.

Mikael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]