This is the mail archive of the
mailing list for the GCC project.
Re: [Patch Darwin 2/2] fix PPC64 ABI
On 24 Jul 2010, at 11:13, Nathan Froyd wrote:
On Sat, Jul 24, 2010 at 09:36:14AM +0100, IainS wrote:
--- gcc/config/rs6000/rs6000.c (revision 162457)
+++ gcc/config/rs6000/rs6000.c (working copy)
@@ -8931,6 +8995,51 @@ rs6000_gimplify_va_arg (tree valist, tree
return build_va_arg_indirect_ref (t);
Could we avoid introducing more #if TARGET_MACHO where it's not
necessary? It should be sufficient to say something like:
&& integer_zerop (TYPE_SIZE (type)))
and the compiler will DTRT and fold out that code for non-Darwin
targets. (This comment applies equally to your other darwin64 patch.)
sure, if that's the preference, no problem.
I guess I was thinking that it would be better to eliminate the code