This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch Darwin 2/2] fix PPC64 ABI



On 24 Jul 2010, at 11:13, Nathan Froyd wrote:


On Sat, Jul 24, 2010 at 09:36:14AM +0100, IainS wrote:
Index: gcc/config/rs6000/rs6000.c
===================================================================
--- gcc/config/rs6000/rs6000.c (revision 162457)
+++ gcc/config/rs6000/rs6000.c (working copy)
@@ -8931,6 +8995,51 @@ rs6000_gimplify_va_arg (tree valist, tree type,
gi
return build_va_arg_indirect_ref (t);
}


+#if TARGET_MACHO

Could we avoid introducing more #if TARGET_MACHO where it's not necessary? It should be sufficient to say something like:

 if (TARGET_MACHO
     && rs6000_darwin_abi
     && integer_zerop (TYPE_SIZE (type)))
   ...

and the compiler will DTRT and fold out that code for non-Darwin
targets.  (This comment applies equally to your other darwin64 patch.)

sure, if that's the preference, no problem.
I guess I was thinking that it would be better to eliminate the code at pre-processing
cheers,
Iain



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]