This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [testsuite] Increase gcc.dg/pr43058.c timeout


On Fri, Jul 23, 2010 at 7:30 PM, Mike Stump <mikestump@comcast.net> wrote:
> On Jul 14, 2010, at 8:47 AM, Rainer Orth wrote:
>> The gcc.dg/pr43058.c test times out on most of my systems:
>>
>> WARNING: program timed out.
>> FAIL: gcc.dg/pr43058.c (test for excess errors)
>>
>> Even on an idle Sun Fire T5220 (1.2 GHz UltraSPARC-T2), it takes
>>
>> real ? ? 4:56.38
>> user ? ? 4:54.71
>> sys ? ? ? ? 0.35
>>
>> or on an Sun Fire X4450 (2.93 GHz Xeon X7350)
>>
>> real ? ? 1:18.01
>> user ? ? 1:17.20
>> sys ? ? ? ? 0.26
>>
>> As soon as the machine is loaded (e.g. make -j<2 * ncpu> check), the
>> test is practically guaranteed not to complete within the regular 5
>> minute (300 s) timeout. ?I'd therefore like to increase the timeout by a
>> factor of 4.
>>
>> Ok for mainline and the 4.5 branch?
>
> No. ?I think the patch is wrong. ?I think the patch is wrong because the testcase is wrong. ?The testcase is wrong, as it intentionally consumes tons of resource to try and blow the machine out of the water.
>
> I think 43058 should be re-opened.

Well - it was fixed (it was about memory consumption).  And to not regress
we need to simulate the original failure which the testcase does.

Now, as for slow machines I'd rather have a { dg-effective-target fast-and-big }
that will just skip these kind of tests on small/slow machines.

Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]