This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Check AVX runtime support


On Fri, Jul 23, 2010 at 11:07:41AM +0200, Rainer Orth wrote:
> Uros Bizjak <ubizjak@gmail.com> writes:
> 
> > Please note that compile tests don't need effective-target check.
> 
> Of course they do, to make sure that the assembler is capable of
> assembling the compiler output (think Solaris 8/9 as).  We just don't
> need both, say, sse2 and sse2_runtime with your patch, which is nice.

{ dg-do compile } tests aren't assembled, it is just -S mode, so I don't see
why would you need that.  For { dg-do assemble } tests (or link or run)
you would need that.

> > Index: gcc.dg/pr34856.c
> > ===================================================================
> > --- gcc.dg/pr34856.c	(revision 162422)
> > +++ gcc.dg/pr34856.c	(working copy)
> > @@ -1,7 +1,6 @@
> >  /* { dg-do compile } */
> >  /* { dg-options "-O2" } */
> >  /* { dg-options "-O2 -msse2" { target { i?86-*-* x86_64-*-* } } } */
> > -/* { dg-require-effective-target sse2 { target { i?86-*-* x86_64-*-* } } } */
> >  /* { dg-options "-O2 -maltivec" { target { powerpc*-*-linux* && powerpc_altivec_ok } } } */
> 
> Need to keep dg-require-effective-target sse2 here.

I don't think so.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]