This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, middle-end] Fix PR 44878, IA64 build failure, partial inlining


On 07/21/2010 02:00 PM, Steve Ellcey wrote:
> +      enum machine_mode mode;
> +      if (DECL_BY_REFERENCE (decl))
> +        mode = promote_function_mode (type, old_mode, &unsignedp, funtype, 2);
> +      else
> +        mode = promote_function_mode (type, old_mode, &unsignedp, funtype, 1);

I think the logic is good.  I would merely combine the two calls:

  mode = promote_function_mode (type, old_mode, &unsignedp, funtype,
				(DECL_BY_REFERENCE (decl) ? 2 : 1));


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]