This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Switch cgraph to IPA_SSA state reliably


On 07/15/2010 02:42 PM, Richard Henderson wrote:
> On 07/15/2010 12:44 PM, Richard Henderson wrote:
>>> -  /* If pass_all_early_optimizations was not scheduled, the state of
>>> -     the cgraph will not be properly updated.  Update it now.  */
>>> -  if (cgraph_state < CGRAPH_STATE_IPA_SSA)
>>> -    cgraph_state = CGRAPH_STATE_IPA_SSA;
>>> +  /* We should have run pass_early_local_passes, which updated this state.  */
>>> +  gcc_assert (cgraph_state >= CGRAPH_STATE_IPA_SSA);
>>
>> Ignore this hunk for the moment; it fails for all LTO tests.  However, I suspect
>> that somewhere in the LTO path we should have set the state more correctly.
> 
> Bootstrap and test on x86_64-linux succeeds without this hunk.

I committed the patch.



r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]