This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, updated] Make emulated TLS lto-friendly.


Hello Richard,
Thanks for the review and sorry about the typographical nits...
I'll re-work the other things and investigate the alias oracle.

one question tho:

On 8 Jul 2010, at 00:22, Richard Henderson wrote:

+ /* ??? It is not enough to check DECL_COMMON because variables might be
+ allocated in other uninitialized sections. However, this might still
+ not be an adequate test. */
+ if (DECL_INITIAL (h->to))

Huh? Why is DECL_COMMON not sufficient?

int foo (void) { static __thread int a; return a; }

places __emutls_v.a.1700 in .lcomm and therefore needs an initializer, but the decl is not marked DECL_COMMON.
do you believe that indicates a bug elsewhere, or is it a reasonable explanation?


thanks
Iain


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]