This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/4] Add the -floop-if-convert flag.


On Wed, Jul 7, 2010 at 16:39, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Wed, Jul 7, 2010 at 10:22 PM, Sebastian Pop <sebpop@gmail.com> wrote:
>> ? ? ? ?* common.opt (floop-if-convert): New flag.
>> ? ? ? ?* doc/invoke.texi (floop-if-convert): Documented.
>> ? ? ? ?* tree-if-conv.c (gate_tree_if_conversion): Enable if-conversion
>> ? ? ? ?when flag_loop_if_convert is set.
>> ---
>> ?gcc/common.opt ? ? ?| ? ?4 ++++
>> ?gcc/doc/invoke.texi | ? 10 ++++++++--
>> ?gcc/tree-if-conv.c ?| ? ?3 ++-
>> ?3 files changed, 14 insertions(+), 3 deletions(-)
>>
>> diff --git a/gcc/common.opt b/gcc/common.opt
>> index 6ca787a..2a5d391 100644
>> --- a/gcc/common.opt
>> +++ b/gcc/common.opt
>> @@ -653,6 +653,10 @@ fif-conversion2
>> ?Common Report Var(flag_if_conversion2) Optimization
>> ?Perform conversion of conditional jumps to conditional execution
>>
>> +floop-if-convert
>> +Common Report Var(flag_loop_if_convert) Optimization
>> +Convert conditional jumps in innermost loops to branchless equivalents
>> +
>
> Init(0) is missing. ?Also can you name it -ftree-loop-if-conversion instead
> consistent with -ftree-loop-* and -fif-conversion.
>

Ok, I will do this.
Although, I do not like the "tree" in the flags, as I find that there is no
reason to expose the internals of GCC to GCC users.

> There is still no way to disable if-conversion if the vectorizer is enabled,
> so I guess a tri-state -1, disabled and enabled would be more useful
> (as you wanted it for debugging in the first place).
>

Good idea.
I will post an updated patch with these modifications.

Sebastian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]