This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [trans-mem] issue with openmp
- From: Richard Henderson <rth at redhat dot com>
- To: Aldy Hernandez <aldyh at redhat dot com>
- Cc: Patrick Marlier <patrick dot marlier at unine dot ch>, FELBER Pascal <pascal dot felber at unine dot ch>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 06 Jul 2010 10:48:20 -0700
- Subject: Re: [trans-mem] issue with openmp
- References: <4C04C24A.4080103@unine.ch> <20100618153140.GB7343@redhat.com> <4C221F08.2020403@unine.ch> <20100623172043.GB19259@redhat.com> <4C225BC3.9010301@unine.ch> <20100706162920.GA20816@redhat.com>
On 07/06/2010 09:29 AM, Aldy Hernandez wrote:
> -__attribute__((transaction_pure))
> -extern void _ITM_dropReferences (void *, size_t) ITM_REGPARM;
> +extern void _ITM_dropReferences (void *, size_t) ITM_REGPARM ITM_PURE;
> +
> +__attribute__((__malloc__)) ITM_REGPARM ITM_PURE
> +extern void *_ITM_malloc (size_t);
> +__attribute__((__malloc__)) ITM_REGPARM ITM_PURE
> +extern void *_ITM_calloc (size_t, size_t);
> +extern void _ITM_free (void *) ITM_REGPARM ITM_PURE;
I'm not sure that _ITM_malloc et al should include ITM_REGPARM.
Also, it's canonical to place these attributes before the ";",
not before the "extern".
r~