This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Support AVX Programming Reference (June, 2010)


On Mon, 2010-07-05 at 10:56 -0700, H.J. Lu wrote:

> > 
> > This patch implements FSGSBASE, RDRND and F16C intrinsic supprot for
> > AVX Programming Reference (June, 2010):
> > 
> > http://software.intel.com/en-us/avx/
> > 
> > Tested on Linux/x86-64.  OK for trunk?
> 
> Hi,
> 
> Here is the updated patch to fix rdrand.  The RDRND new instruction
> should be rdrand, instead of rdrnd.  OK for trunk?

Please remove unneeded comments about 16/32bit rdrand and 32/64bit
{rd,wr}{fs,gs}base from immintrin.h. The functionality should be obvious
from function names.

Also, anything that touches any header under x86intrin.h should be
tested in gcc.target/i386/sse-{12,13,14,22,23}.c as well as g
++.dg/other/i386-{2,3}.C to ensure that headers play well together.

The patch is OK for mainline, but please also post a follow-up patch
that tests header changes as suggested above.

Thanks,
Uros.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]