This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix unresolved symbols during Mozilla WHOPR build


> > +static void
> > +add_references_to_partition (ltrans_partition part, struct ipa_ref_list *refs)
> > +{
> > +  int i;
> > +  struct ipa_ref *ref;
> > +  for (i = 0; ipa_ref_list_reference_iterate (refs, i, ref); i++)
> > +    {
> > +      if (ref->refered_type == IPA_REF_CGRAPH
> > +	  && DECL_COMDAT (ipa_ref_node (ref)->decl)
> > +	  && !cgraph_node_in_set_p (ipa_ref_node (ref), part->cgraph_set))
> > +	add_cgraph_node_to_partition (part, ipa_ref_node (ref));
> > +      else
> > +	if (ref->refered_type == IPA_REF_VARPOOL
> > +	    && DECL_COMDAT (ipa_ref_varpool_node (ref)->decl)
> > +	    && !varpool_node_in_set_p (ipa_ref_varpool_node (ref), part->varpool_set))
> > +	  add_varpool_node_to_partition (part, ipa_ref_varpool_node (ref));
> 
> Do we need to make sure to add all members of a comdat group here?

I think so, yes.  We still need to play that comdat group game correctly.  Adding just part
of comdat group would result in incorrect linking.
With 1-1 map the problem never happens.
> 
> diff -c please ...

This is svn setup on evans.  I fixed it now.

Honza


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]